docs(microsoft): document batchGroupLookups option#216
Open
XDanny322 wants to merge 3 commits into
Open
Conversation
XDanny322
force-pushed
the
main
branch
3 times, most recently
from
95a1c48 to
dddb220
Compare
…and configuration details xref dexidp/dex#4833 Signed-off-by: Danny Lai <xdanny322@gmail.com>
matheuscscp
reviewed
Jul 9, 2026
Comment on lines
+213
to
+223
| By default, dex resolves group ids to group names with a single request to | ||
| the Microsoft Graph API. Microsoft Graph's | ||
| [`directoryObjects/getByIds`](https://learn.microsoft.com/en-us/graph/api/directoryobject-getbyids) | ||
| endpoint caps that request at 1000 ids, so a user who is a member of more | ||
| than 1000 groups will fail to log in. | ||
|
|
||
| Setting the `batchGroupLookups` (boolean) configuration option splits the | ||
| lookup into batches of 1000 group ids, supporting users with larger group | ||
| memberships. This is opt-in because it trades that login failure for | ||
| additional requests to the Microsoft Graph API — one extra request per 1000 | ||
| groups a user belongs to — which may not be desirable for every deployment. |
There was a problem hiding this comment.
Sounds like slop, we could document everything here in 3~4 lines
Author
There was a problem hiding this comment.
OK, i tighten this a bit. Added the comment inline, within the same "group" archor. Also took this chance to add the header size note.
Looks something like this.
Move the >1000 groups caveat next to groupNameFormat since it only applies to name resolution, and note that resolving large group counts can produce a JWT big enough to need ingress/gateway header buffer tuning. Signed-off-by: Danny Lai <xdanny322@gmail.com>
matheuscscp
reviewed
Jul 10, 2026
matheuscscp
left a comment
matheuscscp
left a comment
There was a problem hiding this comment.
Thanks @XDanny322, the example was good but the two paragraphs were together too large
Show a concrete config snippet demonstrating batchGroupLookups: true alongside the prose explaining when it's needed. Signed-off-by: Danny Lai <xdanny322@gmail.com>
Author
|
I added the example back, but left it meshed into the exist resulting: 
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Microsoft connector's group-name resolution sends every group ID a user
belongs to in a single request to Microsoft Graph's
directoryObjects/getByIds endpoint. That endpoint caps requests at 1000 IDs,
so users in more than 1000 groups fail to log in.
dexidp/dex#4833 fixes this by adding a batchGroupLookups config option that
splits the lookup into batches of 1000 IDs. It's opt-in (default off) rather
than always-on.