Skip to content

allow empty DOCKER_DOMAIN_SUFFIX#5

Open
rooterkyberian wants to merge 1 commit into
dex4er:masterfrom
rooterkyberian:no_suffix
Open

allow empty DOCKER_DOMAIN_SUFFIX#5
rooterkyberian wants to merge 1 commit into
dex4er:masterfrom
rooterkyberian:no_suffix

Conversation

@rooterkyberian

Copy link
Copy Markdown

This patch allows complete removal of DOCKER_DOMAIN_SUFFIX during configuration phase, like this:
./configure --prefix=/usr --with-docker-domain-suffix=""

So instead of ping test.docker you can do just ping test, just like you would inside of the container.

@dex4er dex4er self-assigned this Feb 13, 2018
@sitano

sitano commented Mar 21, 2019

Copy link
Copy Markdown

for performance considerations its worth of having some sort of filter for names not to be checked when the suffix is not set. i.e. having dots in the middle (like in google.com) to be excluded. this filter, for example, could be configurable too. I just exclude dots in my branch.

@moschlar

Copy link
Copy Markdown

See also #11

@azazar

azazar commented May 17, 2025

Copy link
Copy Markdown

for performance considerations its worth of having some sort of filter for names not to be checked when the suffix is not set. i.e. having dots in the middle (like in google.com) to be excluded. this filter, for example, could be configurable too. I just exclude dots in my branch.

Docker allows dots in container names so dots should be allowed by resolver too. That filter should be optional and disabled by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants