allow empty DOCKER_DOMAIN_SUFFIX#5
Open
rooterkyberian wants to merge 1 commit into
Open
Conversation
|
for performance considerations its worth of having some sort of filter for names not to be checked when the suffix is not set. i.e. having dots in the middle (like in google.com) to be excluded. this filter, for example, could be configurable too. I just exclude dots in my branch. |
|
See also #11 |
Docker allows dots in container names so dots should be allowed by resolver too. That filter should be optional and disabled by default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch allows complete removal of DOCKER_DOMAIN_SUFFIX during configuration phase, like this:
./configure --prefix=/usr --with-docker-domain-suffix=""So instead of
ping test.dockeryou can do justping test, just like you would inside of the container.