Skip to content

#906: Add feature configurable intellij vm args#1820

Merged
hohwille merged 18 commits intodevonfw:mainfrom
jakozian:feature/906-configurable-intellij-vm-args
Apr 17, 2026
Merged

#906: Add feature configurable intellij vm args#1820
hohwille merged 18 commits intodevonfw:mainfrom
jakozian:feature/906-configurable-intellij-vm-args

Conversation

@jakozian
Copy link
Copy Markdown
Contributor

@jakozian jakozian commented Apr 14, 2026 •
edited
Loading

This PR fixes #906

Implemented changes:

  • Implement feature to configure jvm options for intellij, android-studio and pycharm via ide variable.
  • Added functionality to create a custom .vmoptions file in the workspace folder which is the referenced by the intellij/studio/pycharm env variable IDEA_VM_OPTIONS/STUDIO_VM_OPTIONS/PYCHARM_VM_OPTIONS which extends or overwrites the default jvm options.
  • Added variable to the variables.doc

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Apr 14, 2026
@jakozian jakozian marked this pull request as draft April 14, 2026 09:31
@jakozian jakozian self-assigned this Apr 14, 2026
@jakozian jakozian moved this from 🆕 New to 🏗 In progress in IDEasy board Apr 14, 2026
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 14, 2026 •
edited
Loading

Coverage Report for CI Build 24562855250

Coverage increased (+0.1%) to 70.553%

Details

  • Coverage increased (+0.1%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 16 coverage regressions across 3 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

16 previously-covered lines in 3 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/tool/ide/IdeaBasedIdeToolCommandlet.java 11 80.92%
com/devonfw/tools/ide/tool/intellij/Intellij.java 4 88.52%
com/devonfw/tools/ide/variable/IdeVariables.java 1 94.23%

Coverage Stats

Coverage Status
Relevant Lines: 15139
Covered Lines: 11134
Line Coverage: 73.55%
Relevant Branches: 6734
Covered Branches: 4298
Branch Coverage: 63.83%
Branches in Coverage %: Yes
Coverage Strength: 3.1 hits per line
💛 - Coveralls

@jakozian jakozian changed the title #906 Add feature configurable intellij vm args #906: Add feature configurable intellij vm args Apr 15, 2026
@jakozian jakozian added intellij IntelliJ IDE from Jet-Brains configuration should be configurable or configuration change enhancement New feature or request labels Apr 15, 2026
@jakozian jakozian moved this from 🏗 In progress to Team Review in IDEasy board Apr 15, 2026
@jakozian jakozian moved this from Team Review to 🏗 In progress in IDEasy board Apr 15, 2026
@jakozian jakozian added android-studio Android Studio IDE from Jet-Brains pycharm python IDE integration labels Apr 15, 2026
jakozian added 2 commits April 15, 2026 13:59
@jakozian
devonfw#906: Move jvm options logic to super class IdeaBasedIdeToolCo…
fcde4b5 
…mmandlet to work for every ide-based tool and add method getIdeProductPrefix
@jakozian
devonfw#906: Add real resolve under MacOS because sym link to binary …
04726a2 
…path is no real binary path
@jakozian jakozian marked this pull request as ready for review April 15, 2026 13:00
@jakozian
Copy link
Copy Markdown
Contributor Author

jakozian commented Apr 15, 2026 •
edited
Loading

Maybe commented out examples for the variables could be added to ide-settings/templates/conf/ide.properties like ECLIPSE_VMARGS.

@jakozian jakozian moved this from 🏗 In progress to Team Review in IDEasy board Apr 15, 2026
@jakozian jakozian requested a review from MarvMa April 16, 2026 05:39
MarvMa
MarvMa approved these changes Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@MarvMa MarvMa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work! I tested the functionality manually on MacOS ARM64 and it worked perfectly. I left a few comments but i couldn't find anything big. 👍

Comment thread cli/src/main/java/com/devonfw/tools/ide/tool/ide/IdeaBasedIdeToolCommandlet.java Outdated
Comment thread cli/src/main/java/com/devonfw/tools/ide/tool/ide/IdeaBasedIdeToolCommandlet.java Outdated
Comment thread CHANGELOG.adoc Outdated
jakozian and others added 3 commits April 16, 2026 14:46
@jakozian @MarvMa
Update cli/src/main/java/com/devonfw/tools/ide/tool/ide/IdeaBasedIdeT…
d606fa8 
…oolCommandlet.java


Rename boolean method to fulfill convention

Co-authored-by: MarvMa <marvin.meitzner@gmail.com>
@jakozian
Update CHANGELOG.adoc
b0319ed
@jakozian
devonfw#906: Replace reusable strings with constants and rename boole…
5e4c3ba 
…an method
@MarvMa MarvMa requested a review from hohwille April 17, 2026 08:17
@MarvMa MarvMa moved this from Team Review to 👀 In review in IDEasy board Apr 17, 2026
hohwille
hohwille approved these changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakozian thanks for your PR. You perfectly solved this for all JetBrains IDEs nicely with reuse and extending the JUnits, etc. Awesome job 👍
FYI: e.g. for IntelliJ the exact same test already exists where you could have just added the new assertion. There is nothing wrong with what you did but test-duration increases this way since we 3x times more do the same recursive deletion and copying + commandlet execution. However, I do not want to block this merge for such detail of perfection.
Lets rather get this into our release today.

The only issue I found is for the changelog. I added a constructive review suggestion that I will immediately commit. But please consider for future PRs.

Comment thread CHANGELOG.adoc Outdated
@hohwille hohwille added this to the release:2026.04.002 milestone Apr 17, 2026
@hohwille hohwille merged commit 63cf7fc into devonfw:main Apr 17, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in IDEasy board Apr 17, 2026
MarvMa added a commit to MarvMa/IDEasy that referenced this pull request Apr 20, 2026
@jakozian @MarvMa @hohwille
devonfw#906: Add feature configurable intellij vm args (devonfw#1820)
2bcde06 
Co-authored-by: MarvMa <marvin.meitzner@gmail.com>
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
@jakozian jakozian deleted the feature/906-configurable-intellij-vm-args branch April 22, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hohwille hohwille hohwille approved these changes

+1 more reviewer

@MarvMa MarvMa MarvMa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MarvMa MarvMa

@jakozian jakozian

Labels

android-studio Android Studio IDE from Jet-Brains configuration should be configurable or configuration change enhancement New feature or request intellij IntelliJ IDE from Jet-Brains pycharm python IDE integration

Projects

IDEasy board
Status: ✅ Done

Milestone

release:2026.04.002

Development

Successfully merging this pull request may close these issues.

Introduce variables INTELLIJ_VM_ARGS, ANDROID_STUDIO_VM_ARGS and PYCHARM_VM_ARGS to configure jvm options for JetBrains IDEs

4 participants

@jakozian @coveralls @hohwille @MarvMa