#1815: Suppress update notification while updating#1816
Merged
hohwille merged 6 commits intodevonfw:mainfrom Apr 22, 2026
Merged
#1815: Suppress update notification while updating#1816hohwille merged 6 commits intodevonfw:mainfrom
hohwille merged 6 commits intodevonfw:mainfrom
Conversation
Collaborator
Coverage Report for CI Build 24763506231Coverage decreased (-0.04%) to 70.618%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions134 previously-covered lines in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
hohwille
approved these changes
Apr 17, 2026
Member
hohwille
left a comment
There was a problem hiding this comment.
@areinicke thanks for your PR. You picked the right spot where to fix that and your check for the update seems to work in most cases. 👍
For 100% correctness, I added a review comment to improve your code. Please have a look.
I would suggest to do the cmd instanceof UpdateCommandlet check already in an outer if statement and then we do nothing (not even evaluate isSettingsRepositorySymlinkOrJunction() in case the update commandlet was invoked).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1815
Implemented changes:
ide updateChecklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal