Skip to content

#1270: Load global user settings outside project#1813

Merged
hohwille merged 11 commits intodevonfw:mainfrom
ducminh02:fix/1270-load-global-user-settings-outside-project
Apr 23, 2026
Merged

#1270: Load global user settings outside project#1813
hohwille merged 11 commits intodevonfw:mainfrom
ducminh02:fix/1270-load-global-user-settings-outside-project

Conversation

@ducminh02
Copy link
Copy Markdown
Contributor

@ducminh02 ducminh02 commented Apr 10, 2026

This PR fixes #1270

Implemented changes:

  • Updated setUserHome to refresh dependent paths (userHomeIde, downloadPath) and reset variables. This ensures tests using isolated user homes correctly load local configurations like ide.properties.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 10, 2026

Coverage Report for CI Build 24844767560

Coverage increased (+0.03%) to 70.64%

Details

  • Coverage increased (+0.03%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 109 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

109 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/context/AbstractIdeContext.java 108 65.19%
com/devonfw/tools/ide/commandlet/EnvironmentCommandlet.java 1 94.44%

Coverage Stats

Coverage Status
Relevant Lines: 15234
Covered Lines: 11218
Line Coverage: 73.64%
Relevant Branches: 6786
Covered Branches: 4337
Branch Coverage: 63.91%
Branches in Coverage %: Yes
Coverage Strength: 3.11 hits per line

💛 - Coveralls

@ducminh02 ducminh02 moved this from 🆕 New to 🏗 In progress in IDEasy board Apr 10, 2026
@ducminh02 ducminh02 marked this pull request as ready for review April 10, 2026 10:53
@ducminh02 ducminh02 self-assigned this Apr 10, 2026
@hohwille hohwille moved this from 🏗 In progress to Team Review in IDEasy board Apr 13, 2026
Copy link
Copy Markdown
Contributor

@MarvMa MarvMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look useful to prevent the Bug from occurring in the feature. Nice Work 👍

@hohwille hohwille moved this from Team Review to 👀 In review in IDEasy board Apr 15, 2026
@MarvMa MarvMa requested a review from hohwille April 16, 2026 07:40
Copy link
Copy Markdown
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ducminh02 thanks for your PR. You did a great job to implement this story 👍
I found some things you missed out. Do not worry too much, since one needs a lot of deep knowledge of IDEasy to understand the coherences but with an end user test via native image this would have been revealed. I plan a KT session with the team about this for the next future...

Copy link
Copy Markdown
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ducminh02 thanks for your improvement. Excellent. Now everything should work perfectly correct. 👍
Ready for merge.

@hohwille hohwille added this to the release:2026.05.001 milestone Apr 23, 2026
@hohwille hohwille merged commit 366193e into devonfw:main Apr 23, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in IDEasy board Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

IDEasy does not load global user settings if outside a project

4 participants