#1270: Load global user settings outside project#1813
#1270: Load global user settings outside project#1813hohwille merged 11 commits intodevonfw:mainfrom
Conversation
Coverage Report for CI Build 24844767560Coverage increased (+0.03%) to 70.64%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions109 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
MarvMa
left a comment
There was a problem hiding this comment.
The changes look useful to prevent the Bug from occurring in the feature. Nice Work 👍
hohwille
left a comment
There was a problem hiding this comment.
@ducminh02 thanks for your PR. You did a great job to implement this story 👍
I found some things you missed out. Do not worry too much, since one needs a lot of deep knowledge of IDEasy to understand the coherences but with an end user test via native image this would have been revealed. I plan a KT session with the team about this for the next future...
hohwille
left a comment
There was a problem hiding this comment.
@ducminh02 thanks for your improvement. Excellent. Now everything should work perfectly correct. 👍
Ready for merge.
This PR fixes #1270
Implemented changes:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal