#913: Add support for SQuirreL SQL Client#1811
Merged
hohwille merged 21 commits intodevonfw:mainfrom Apr 23, 2026
Merged
Conversation
…ol to squirrel-sql
Collaborator
Coverage Report for CI Build 24843380566Coverage decreased (-0.02%) to 70.619%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions24 previously-covered lines in 3 files lost coverage.
Coverage Stats💛 - Coveralls |
ducminh02
reviewed
Apr 14, 2026
…relSql.java Add administration tool tag
ducminh02
approved these changes
Apr 14, 2026
hohwille
approved these changes
Apr 23, 2026
Member
hohwille
left a comment
There was a problem hiding this comment.
@jakozian thanks for your PR. You nicely implemented both UrlUpdater and the commandlet including all tests. Excellent work 👍
p.s: You are not covering the run method in your test (and would also need to include the mac script to make that work). This should not prevent the merge but for tests it is always good to cover the methods - esp. OS specific if / else blocks...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #913
Implemented changes:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalChecklist for tool commandlets
Have you added a new
«tool»as commandlet? There are the following additional checks:«tool»«TOOL»_VERSIONand«TOOL»_EDITIONare honored by your commandlet