Skip to content

fix: usersummary에 servername 추가#182

Merged
LeeShinHaeng merged 3 commits into
devfrom
fix/usersummary-servername-nickname
Apr 4, 2026
Merged

fix: usersummary에 servername 추가#182
LeeShinHaeng merged 3 commits into
devfrom
fix/usersummary-servername-nickname

Conversation

@LeeShinHaeng
Copy link
Copy Markdown
Contributor

📋 상세 설명

  • usersummary에 server_name 컬럼을 추가했습니다.
  • nickname에 단일 유니크 설정을 해제했습니다.
  • server_name과 nickname에 복합 유니크 설정을 추가했습니다.

📊 체크리스트

  • PR 제목이 형식에 맞나요 e.g. feat: PR을 등록한다
  • 코드가 테스트 되었나요
  • 문서는 업데이트 되었나요
  • 불필요한 코드를 제거했나요
  • 이슈와 라벨이 등록되었나요

📆 마감일

Close #181

@LeeShinHaeng LeeShinHaeng requested review from bsko98 and dev-ant March 23, 2026 11:25
@LeeShinHaeng LeeShinHaeng self-assigned this Mar 23, 2026
@LeeShinHaeng LeeShinHaeng added 🐛bug 긴급하지 않은 버그 리포트 🗂️chore 간단한 업무 labels Mar 23, 2026
@github-actions
Copy link
Copy Markdown

Unit Test Results

  39 files  ±0    39 suites  ±0   4s ⏱️ ±0s
128 tests ±0  128 ✔️ ±0  0 💤 ±0  0 ±0 
129 runs  ±0  129 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit c7d01da. ± Comparison against base commit 80cc2b3.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...e/eternity/dcs/domain/user/entity/UserSummary.java 50.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@LeeShinHaeng LeeShinHaeng linked an issue Mar 23, 2026 that may be closed by this pull request
2 tasks
Copy link
Copy Markdown
Collaborator

@bsko98 bsko98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 고생 많으셨습니다. 👍 👍
이래저래 요즘 일이 많아서 리뷰가 늦은점 너무 죄송합니다.

@LeeShinHaeng LeeShinHaeng merged commit 6fc9cc1 into dev Apr 4, 2026
3 checks passed
@LeeShinHaeng LeeShinHaeng deleted the fix/usersummary-servername-nickname branch April 4, 2026 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛bug 긴급하지 않은 버그 리포트 🗂️chore 간단한 업무

Projects

None yet

Development

Successfully merging this pull request may close these issues.

유저 닉네임 중복 가능으로 변경

2 participants