Skip to content

dsl: Dimension off by one mistake#2881

Closed
JDBetteridge wants to merge 1 commit intomainfrom
JDBetteridge/dimension_hotfix
Closed

dsl: Dimension off by one mistake#2881
JDBetteridge wants to merge 1 commit intomainfrom
JDBetteridge/dimension_hotfix

Conversation

@JDBetteridge
Copy link
Copy Markdown
Contributor

As reported by Dylan Stark, an off-by-one in ConditionalDimension._arg_defaults breaks decoupler time_M reduction.

@JDBetteridge JDBetteridge added bug-py compiler python Pull requests that update python code labels Apr 13, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.18%. Comparing base (8c448dc) to head (dab7d2a).
⚠️ Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (8c448dc) and HEAD (dab7d2a). Click for more details.

HEAD has 12 uploads less than BASE
Flag BASE (8c448dc) HEAD (dab7d2a)
18 9
pytest-gpu-gcc- 6 4
pytest-gpu-icx- 3 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2881       +/-   ##
===========================================
- Coverage   83.44%   52.18%   -31.26%     
===========================================
  Files         248      242        -6     
  Lines       51311    50751      -560     
  Branches     4428     4402       -26     
===========================================
- Hits        42817    26485    -16332     
- Misses       7738    23317    +15579     
- Partials      756      949      +193     
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.81% <100.00%> (ø)
pytest-gpu-gcc- 43.46% <0.00%> (-34.58%) ⬇️
pytest-gpu-icx- 43.31% <0.00%> (-34.34%) ⬇️
pytest-gpu-nvc-nvidiaX 69.33% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@EdCaunt EdCaunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable once green

@JDBetteridge JDBetteridge added the invalid This doesn't seem right label Apr 14, 2026
@JDBetteridge
Copy link
Copy Markdown
Contributor Author

Adding the invalid label as the initial bug report may have been incorrect

@JDBetteridge JDBetteridge marked this pull request as draft April 14, 2026 09:46
@mloubout
Copy link
Copy Markdown
Contributor

Fixed in #2883

@mloubout mloubout closed this Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-py compiler invalid This doesn't seem right python Pull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants