fix(harness): detect clipped shading occlusion - #1452
Merged
developer0hye merged 1 commit intoAug 31, 2026
Conversation
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clip_path,fill_shade, andpop_clipoperations in trace order so the layout audit can recognize text hidden by a later opaque clipped shading.nested clip scope, self-intersecting paths, and multiple subpaths.
Related issue
Fixes #1450
Testing
python3 -m unittest scripts.tests.test_compare_layout.MatchAndDiffTest.test_same_text_hidden_by_later_clipped_shading_reports_visibility_mismatchfailed before the implementation withAssertionError: 0 != 1.python3 -m unittest scripts.tests.test_compare_layout(35 passed)python3 -m unittest scripts.tests.test_check_visual_pr scripts.tests.test_probe_harness scripts.tests.test_check_layout_baselines scripts.tests.test_generate_layout_baselines(118 passed)python3 -m unittest discover -s scripts/tests(275 passed)python3 scripts/compare_layout.py --json GT.pdf OUTPUT.pdfagainst the PR fix(docx): honor in-cell picture row floors #1407 / issue Place your event title here.docx #1219 two-page PDFs: page-1Sensitivity:Internalchanges from the falseGT hidden vs output paintedmismatch tohiddenon both sides; page 2 remains painted on both sides. The report diff contains no other change, and the remaining layout findings stay tracked in DOCX missing-font selection changes table wrapping and placement across hosts #1409.git diff --checkPASSVisual impact
Checklist
Signed-off-byline