fix(docx): seat bottom-anchored footer text - #1451
Merged
Merged
Conversation
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue
Fixes #1370
Testing
CARGO_TARGET_DIR=/Volumes/T7/targets/office2pdf-issue-1370 cargo test -p office2pdf --lib a_bottom_seated_anchored_frame_keeps_one_em_above_its_bottom_inset -- --nocapturefailed before the implementation:bottom-seated 8pt baseline 826.89pt should be 818.89pt.CARGO_TARGET_DIR=/Volumes/T7/targets/office2pdf-issue-1370 cargo test -p office2pdf --lib a_bottom_seated_anchored_frame_keeps_one_em_above_its_bottom_inset -- --nocapture(1 passed; 8pt, 12pt, and unstated/11pt-default PDF probes)CARGO_TARGET_DIR=/Volumes/T7/targets/office2pdf-issue-1370 cargo test -p office2pdf --lib render::typst_gen::tests::page_misc_tests -- --nocapture(79 passed)CARGO_TARGET_DIR=/Volumes/T7/targets/office2pdf-issue-1370 cargo test -p office2pdf --lib parser::docx::sections::anchor_tests -- --nocaptureCARGO_TARGET_DIR=/Volumes/T7/targets/office2pdf-issue-1370 cargo test --workspacepython3 -m unittest discover -s scripts/tests(266 passed)cargo fmt --all -- --checkgit diff --check8d9423e06d25bc27393d6fe484d3febcbbedc9ff71d72cd07b708bffe434b2d4).python3 scripts/compare_layout.py --json --audit gt.pdf after.pdf(expected nonzero; remaining findings dispositioned to DOCX missing-font selection changes table wrapping and placement across hosts #1409 and Harness: detect text occluded by clipped opaque shadings #1450)python3 scripts/compare_render.py --page 1 --dpi 300 --audit --lines --artifacts-dir ... gt.pdf after.pdfand page 2 equivalent (expected nonzero; remaining text shifts dispositioned to DOCX missing-font selection changes table wrapping and placement across hosts #1409)PASSVisual impact
Visual audit
Place your event title here.docxpdftoppm, 300 DPI inspection; stored progressive JPEG evidence at 150 DPIfixassets/bugfixes/issue-1370/layout-audit.jsonSensitivity: Internalbehind the body artwork, while the PDF text layer preserves it. The rotated photo, orange diamond, dot fields, gradients, circle, triangles, and white rules retain their geometry, fill, stroke, and orientation. Remaining title/body family and weight differences,WELCOMEwrapping, subtitle/gate/RSVP shifts, and related alignment differences are DOCX missing-font selection changes table wrapping and placement across hosts #1409. The layout harness's falsepaintedclassification for the correctly occluded page-1 footer is Harness: detect text occluded by clipped opaque shadings #1450.assets/bugfixes/issue-1370/gt.jpgassets/bugfixes/issue-1370/before.jpgassets/bugfixes/issue-1370/after.jpgVisual comparison
Required inspection
Deviation audit
ALL,AGES, gate, and RSVP shifts; the page-2 footer baseline is fixed to within 0.05pt of GTWELCOMEline grouping plus the measured text shiftsWELCOMEoverflow versus GT's four-line wrap; #1450 tracks the audit harness's false visibility classification for the correctly occluded page-1 footerChecklist
Signed-off-byline