fix(pptx): scale right legend row pitch - #1448
Merged
Merged
Conversation
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue
Fixes #1434
Testing
cargo test -p office2pdf a_powerpoint_column_right_legend_uses_the_native_text_scaled_row_pitch -- --nocapturefailed before the implementation with[14.0, 14.0]row pitches instead of the native 19.2pt pitch.cargo test -p office2pdf a_powerpoint_column_right_legend_uses_the_native_text_scaled_row_pitch -- --nocapture— passed; the PowerPoint column/right path is within 0.1pt of 19.2pt and the PowerPoint bar control remains 14pt.cargo test -p office2pdf --lib diagram_visual_tests -- --nocapture— 202 passed.python3 -m unittest discover -s scripts/tests -p 'test_compare_render.py'— 26 passed.python3 -m unittest discover -s scripts/tests -p 'test_compare_layout.py'— 26 passed.python3 -m unittest discover -s scripts/tests -p 'test_check_visual_pr.py'— 42 passed.CARGO_INCREMENTAL=0 cargo clippy --workspace --all-targets -- -D warnings— passed.CARGO_INCREMENTAL=0 cargo test --workspace— core 2,756; DOCX 188; PDF validation 7; PPTX 130; XLSX 206; CLI 17; package/model roundtrip and doctests all passed with zero failures.python3 scripts/compare_render.py native-powerpoint.pdf office2pdf.pdf --page 8 --dpi 300 --audit --artifacts-dir ...— all six GT text lines matched; the remaining three >5pt shifts are the shared legend block offsets tracked by PPTX column-chart right legends center 9.2pt too low #1435 and PPTX column-chart right legends are right-fitted 11pt too far left #1436.magick compare -metric AE -fuzz 5% before.png after.png diff.png— 16,447 changed pixels (0.183%), confined to the three legend rows.Visual impact
Visual audit
pdftoppm, 300 DPIassets/bugfixes/issue-1434/layout-audit.jsonassets/bugfixes/issue-1434/gt.jpgassets/bugfixes/issue-1434/before.jpgassets/bugfixes/issue-1434/after.jpgVisual comparison
Required inspection
Deviation audit
Checklist
Signed-off-byline