S440 — sample-theme codeload lock + gate parity (finish-S246) - #1
Merged
Conversation
Add the committed composer.lock (5 require + 28 require-dev, GitHub zipball dists), scripts/security-audit-check.php gate, a last-position composer-audit CI job, and tests/SecurityAuditCheckTest.php. sample-theme is the last of the 11 plugin repos left ungated: S246 recorded it as gated using TRAKT's stats (wrong-directory measurement); the repo itself was never audited on disk.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S440 — sample-theme codeload lock + gate parity (finish-S246)
sample-theme was the last of the 11 plugin repositories with no dependency-drift gate at all: no committed lock, no gate script, no CI leg. The S246 sweep recorded it as gated using TRAKT's statistics (a wrong-directory measurement) — the repo itself was never checked on disk until S440.
This PR brings it to parity with the ten gated siblings (trakt/omdb/anilist/anidb/hub/…), mirroring the trakt/omdb exemplar structure:
composer.lock— committed lock of its actual codeload/GitHub-zipball deps (derived at tip1ea573b): 5 require + 28 require-dev = 33 packages.scripts/security-audit-check.php— the whole-lock audit gate (composer audit --locked, no--no-dev), corpus floored at 28 total / 24 dev..github/workflows/test.yml— acomposer-auditjob (name Security Audit) kept LAST, nocontinue-on-error, noif:, runs onpull_request.tests/SecurityAuditCheckTest.php— the guard test that fails on each neutering edit.Acceptance (planted-drift RED → GREEN)
Against a
/tmpcopy of the real committed lock, driftingsquizlabs/php_codesnifferto the affected4.0.1and planting CVE-2026-67434:Restoring the version / clearing advisories →
Security audit passed.(exit 0). Local suite: phpunit 42/42, phpstan level 9 clean, phpcs clean.Notes
.gitignorestill lists/composer.lock(matching every gated sibling) — the lock is force-added and tracked, exactly as trakt/omdb do.*.mdadded to the repo (P-1).