chore: remove legacy API retirement banner and "Read the update" CTAs#352
Merged
Conversation
This reverts commit 18b11c4.
Remove the global LegacyBanner ("The Deriv legacy API is being retired.")
rendered in the layout, the matching "Read the update" button on the home
hero, and the now-unused localization strings (en + fr).
- Delete src/components/LegacyBanner (component + styles)
- Drop banner render + unused useLocation/pathname in theme/Layout
- Remove "Read the update" button and unused useDocusaurusContext in HeroHeader
- Prune orphaned strings from i18n/en/code.json and i18n/fr/code.json
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maryia-deriv
requested review from
matin-deriv,
mayuran-deriv and
nijil-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Filespackage-lock.json
|
Trivy flagged two HIGH vulnerabilities in the lockfile: - protobufjs 7.5.8 -> 7.6.1 (CVE-2026-48712: DoS via unbounded Any expansion during JSON conversion) - ws 8.20.1 -> 8.21.0 (CVE-2026-48779: memory exhaustion DoS from tiny fragments and data chunks) Both were already pinned via overrides at the vulnerable versions; bump them to the fixed releases and regenerate package-lock.json. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
7.6.1 is affected by CVE-2026-54269 (schema-derived names can shadow runtime-significant properties). Bump to the patched 7.6.3 release. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the legacy-API retirement UI that is no longer needed:
src/components/LegacyBanner(component + styles) — the global bar reading "The Deriv legacy API is being retired."theme/Layoutalong with the now-unuseduseLocation/pathnameHeroHeaderand its unuseduseDocusaurusContext"The Deriv legacy API is being retired.","Read the update") fromi18n/en/code.jsonandi18n/fr/code.jsonNet result: 104 lines deleted, no behavioral additions.
Notes for reviewers
21b2017a "Revert \"JSON Schema Update\"", which is not onmaster. Merging intomasterwill therefore also revert that schema update. Confirm this is intended, or rebase to drop it if you only want the banner removal.src/ori18n/.npm run write-translationswas not run — it only adds missing keys, it doesn't prune, so it's unnecessary for a removal.Test plan
npm run buildsucceeds🤖 Generated with Claude Code