feat(CraftQueue): show if new items were added to the Auctionator shopping list#1389
Open
dilelu94 wants to merge 1 commit into
Open
feat(CraftQueue): show if new items were added to the Auctionator shopping list#1389dilelu94 wants to merge 1 commit into
dilelu94 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a small quality-of-life status to the chat print when creating an Auctionator shopping list.
Currently, it just prints "CraftSim: Created Auctionator Shopping List" regardless of whether any items actually need to be bought. Very often, players already have the required items in their bank or inventory across their crafters. To check if anything is actually missing, they have to run to the Auction House, open the shopping list, and check it.
By checking if the list of search strings has elements (
#searchStrings > 0), we can append either(new items added)or(no items added)at the end of the chat print, instantly letting the player know if they need to visit the Auction House or not.