fix: apply offset queue amount to craft list concentration queue#1383
Open
yltsmees wants to merge 2 commits into
Open
fix: apply offset queue amount to craft list concentration queue#1383yltsmees wants to merge 2 commits into
yltsmees wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes smart concentration queueing in CraftLists.
The previous logic calculated queueableAmount from available concentration, but also used that same value as the final queued amount. This ignored offsetQueueAmount, so extra buffer crafts were not added for expected Ingenuity procs.
This change calculates totalQueueAmount as queueableAmount + offsetQueueAmount, applies maxQueueAmount to the final queued amount, caps SBF crafts to the final queued amount, and only subtracts concentration for the real concentration-limited crafts.
Offset crafts are added as an extra buffer, but they do not consume concentration upfront.