menu: restore focus to feh window after hiding menu#827
Merged
derf merged 1 commit intoderf:masterfrom Apr 26, 2026
Merged
Conversation
focus was set to menu_cover on menu open but never restore on hide (say after performing a File->Delete); on Xwayland RevertToPointerRoot doesn't recover it; added an explicit call to XSetInputFocus back to fehwin->win before destroying the cover window.
Owner
|
Thanks! As a side note, this also provides a minor quality of life improvement on X11 when the menu window is partially outside the feh window, the pointer is on the outside portion, and the user uses mouse input to navigate the meny. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
focus was set to menu_cover on menu open but never restore on hide (say after performing a File->Delete); on Xwayland RevertToPointerRoot doesn't recover it; added an explicit call to XSetInputFocus back to fehwin->win before destroying the cover window.