Skip to content

Add collection count validation in NetDataReaderExtension#100

Open
Riryan wants to merge 2 commits into
masterfrom
Riryan-patch-4
Open

Add collection count validation in NetDataReaderExtension#100
Riryan wants to merge 2 commits into
masterfrom
Riryan-patch-4

Conversation

@Riryan

@Riryan Riryan commented May 25, 2026

Copy link
Copy Markdown
Collaborator

Added validation for collection count in GetArrayExtension, GetArrayObject, and GetList methods. Introduced a constant to limit maximum collection size.

Riryan and others added 2 commits May 25, 2026 17:19
Added validation for collection count in GetArrayExtension, GetArrayObject, and GetList methods. Introduced a constant to limit maximum collection size.

@johnmoney johnmoney left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to remove:

          ///Read a quantized Vector3 from the reader, the vector is quantized into integers based on the cell size and compression mode, which determines how many bits are used for each component.
        public static Vector3 GetQuantizedVector3(this NetDataReader reader, ushort cellSize, out int compressionMode)
        {

Is this intentional? Also please pull request against develop.

@Riryan

Riryan commented May 26, 2026

Copy link
Copy Markdown
Collaborator Author

no access
Screenshot 2026-05-26 184904

@johnmoney

Copy link
Copy Markdown
Contributor

On MmoKitCE, you should be able to switch to develop branch. Let me know if this is not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants