Fix solve_troposphere bug#255
Open
betsy-loaiza wants to merge 1 commit into
Open
Conversation
demiangomez
requested changes
Jun 30, 2026
demiangomez
left a comment
Owner
There was a problem hiding this comment.
Actually, we should not test for list and drop the nargs=1 in the parser.add_argument. That way the parameter will always be an int. Then also remove the solve_troposphere = solve_troposphere[0].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --solve_troposphere argument is defined with nargs=1, so when it is provided on the command line, argparse returns a list instead of an integer. However, the code later expects an integer value.
This causes an issue when the --solve_troposphere option is provided on the command line. The default value is not affected because it is stored as an integer.
This change adds a check to handle the case where solve_troposphere is a list by using its first element.