Fix iframe - #3
Open
Mbalcorta wants to merge 6 commits into
Open
Conversation
tibetsprague
left a comment
tibetsprague
left a comment
There was a problem hiding this comment.
hmm, id like to understand why this works before agreeing that this is the best solution. because this seems like it could break the iframe map
Inserted geojsonEvents function as needed for vue instance of iframe.
Collaborator
Author
|
I looked into it further and iframe does need the geojsonevents function but the order they are initialized in vue affect the view of event map. I'm still investigating why the vue order matters, i'm assuming it has something to do with them sharing the same map id. |
|
That sounds very likely
… On Nov 22, 2017, at 2:44 PM, Mateo Balcorta ***@***.***> wrote:
I looked into it further and iframe does need the geojsonevents function but the order they are initialized in vue affect the view of event map. I'm still investigating why the vue order matters, i'm assuming it has something to do with them sharing the same map id.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAOnVY4LVktIRSbOhMVchR0K25zdJXpks5s5KO5gaJpZM4QoBRe>.
|
Collaborator
Author
|
Change vue template based on href location. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change order of iframe initialization and removed duplicate function from iframe.js