Properly dispose request objects#20
Open
vape wants to merge 1 commit into
Open
Conversation
vape
changed the title
|
why are u not using the using statement? @vape |
Author
|
@ariko-spaceplay well, both calling dispose and using statement is valid options. The only invalid is lack of either. |
|
If an exception is thrown, you’ll never dispose causing a memory leak
…________________________________
From: Artem Sokolov ***@***.***>
Sent: Tuesday, June 28, 2022 5:34:52 PM
To: deltaDNA/unity-sdk ***@***.***>
Cc: Arik Olsh. ***@***.***>; Mention ***@***.***>
Subject: Re: [deltaDNA/unity-sdk] Properly dispose request objects (PR #20)
@ariko-spaceplay<https://github.com/ariko-spaceplay> well, both calling dispose and using statement is valid options. The only invalid is lack of either.
—
Reply to this email directly, view it on GitHub<#20 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AW4P4TAH6QDHZYMQKWTK27LVRMEQZANCNFSM5HFZNIDA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Author
|
@ariko-spaceplay you right. |
|
Hi Artem,
Quick question, is URP better for mobile than the standard pipeline?
I just didn't find a conclusive answer to that.
What are the differences between the two rendering pipelines in terms of
CPU performance, RAM consumption and visuals?
Best, Arik.
…On Tue, Jun 28, 2022 at 7:32 PM Artem Sokolov ***@***.***> wrote:
@ariko-spaceplay <https://github.com/ariko-spaceplay> you right.
—
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AW4P4TCUHWT3ANZSXYLEKELVRMSIBANCNFSM5HFZNIDA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing dispose call. UnityWebRequest object must be disposed after request is completed, otherwise UploadHandler will keep its payload in memory forever and cause memory leak.