Stabilize OpenAI-compatible streamed tool-use test - #283
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 5 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe OpenAI completions provider now propagates the configured parallel tool-call setting. The request type supports the corresponding JSON field. Tests add forced single-tool coverage and normalize assertion ordering. ChangesOpenAI completions tool-call handling
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The OpenAI-compatible adapter now carries the parallel tool-call setting, while streamed single-tool tests explicitly select the tool and disable parallel calls. No current merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Summary
Why
The live test used automatic tool choice while requiring exactly one tool call. OpenAI can validly answer without a tool in that mode, which caused the main-branch CI failure. The assertion arguments were also reversed, so the reported want and got values were misleading.
Validation
Summary by CodeRabbit
New Features
parallel_tool_callsrequest setting.Tests