Ignore a malformed viewBox instead of raising TypeError - #507
Merged
Conversation
get_box parsed the viewBox and returned Box(*values) without checking that it had exactly four numbers, so a viewBox with the wrong number of values (or a non-numeric one) raised TypeError/ValueError. Per the SVG spec an invalid viewBox is ignored, so fall through to the width/height fallback.
Owner
|
Thanks for the fix and tests! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An SVG with a viewBox that isn't four numbers crashes
svg2rlg:get_boxdoesvalues = [float(v) for v in view_box.split()]thenreturn Box(*values)without checking the count, so a viewBox with the wrong number of values raisesTypeError(and a non-numeric one raisesValueError). Per the SVG spec an invalid viewBox is ignored, so I fall through to the existing width/height fallback when it doesn't parse to exactly four numbers. Valid viewBoxes are unaffected.Added a test; it raises TypeError on
mainand passes with the change, and the rest of test_basic.py still passes. Found it by fuzzingsvg2rlgwith mutated SVG.