Remove usage of pull_request_target and GHA secrets from CI#105
Merged
Conversation
Uses the same docker approach from the GC/Wii community. There's a write up about this approach here: AngheloAlf/drmario64#19 The main motivation for getting rid of `pull_request_target` is that it was making this repo a target for bad actors trying to steal repository secrets. `pull_request_target` bypasses the require approval before running CI on a PR check, making it an easy target for bad people. This approach uses a docker image that contains the important and unique dependencies needed to build the repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the same docker approach from the GC/Wii community.
There's a write up about this approach here: AngheloAlf/drmario64#19
The main motivation for getting rid of
pull_request_targetis that it was making this repo a target for bad actors trying to steal repository secrets.pull_request_targetbypasses the require approval before running CI on a PR check, making it an easy target for bad people.This approach uses a docker image that contains the important and unique dependencies needed to build the repo