unify context overflow recovery - #240
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84447ade8c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (!result.ok) { | ||
| const message = `Auto-compaction failed before model call: ${result.error}`; | ||
| const message = trigger === "provider-overflow" | ||
| ? `Auto-compaction failed after provider context overflow: ${result.error}` |
There was a problem hiding this comment.
Highlight overflow compaction failures in chat
When auto-compaction fails after a provider-confirmed overflow, this emits a new system-message prefix, but the chat UI only recognizes Auto-compaction failed before model call: in web/src/app/features/chat/domain/transcript.ts:322-327. In that summary-generation/archive-failure path, the run finishes with status: "error" while both the live proc.changed row and refreshed history render as a neutral system message, hiding the failure from users; please update the web consumer alongside the new gateway format.
AGENTS.md reference: AGENTS.md:L165-L165
Useful? React with 👍 / 👎.
Summary
Validation
cd gateway && npx tsc --noEmit