mc - #238
Draft
deathbyknowledge wants to merge 236 commits into
Draft
Conversation
Owner
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 65a9be4674
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR is
This is the consolidated GSV architecture and product branch. It is intentionally much larger than a normal feature PR: it combines the managed-service work, the one-intelligence interaction model, the native host applications, protocol and media redesigns, dynamic adapters, deployment changes, and the repository-wide boundary/lint cleanup into one coherent release candidate.
The resulting system supports both:
Current diff: 933 files, +197,938 / −82,854.
Product model: one intelligence, everywhere
Conversations, Process activity, and explicit delivery
message sendcommits a user-visible Message without ending the run;yieldexplicitly ends a human-facing run;message send … && yield;yieldcompletes silently.Installation-scoped managed runtime
installationIdthe outer managed security and storage boundary.singletonprojection and legacy RPC arities needed for supported standalone upgrades.Process durability and execution
Canonical resources, media, and streaming
ReadableStreambodies.Unified protocol peers and routing
Adapters
AdapterServicecontract and a data-driven adapter catalog.Managed Telegram
Email
Managed services and public contracts
packages/gsv/src/services/for:Managed inference
Web application
Rust host applications
Reorganizes Rust under one
host/workspace:host/apps/desktop— GPUI Desktop application;host/apps/cli— thegsvCLI;host/apps/machine— thegsvdmachine runtime;host/helpers/transcriberandhost/helpers/gestures;host/crates.Desktop and machine ownership
gsvdthrough cross-platform local IPC.Native gestures and voice
Deployment and releases
gsv deployandgsv infra *CLI deployment paths.Code quality and documentation
Security and data invariants
singletoncompatibility remains explicit.Schema and compatibility notes
Validation performed
Latest release-candidate checks include:
hank.staging.gsv.spaceHTTP smoke check;Expected non-failing diagnostics remain limited to dependency sourcemap notices, the Vite large-chunk advisory, and existing ripgit compiler warnings.
Suggested review order
AGENTS.mdanddocs/architecture/for the target model.packages/gsv/src/services/and protocol maps for public boundaries.gateway/src/kernel/.gateway/src/process/.host/workspace, Desktop↔machine IPC, packaging, gestures, and voice.Deliberately deferred
These are tracked separately rather than hidden inside this PR: