Skip to content

add diatomic download and share utilities from phonons download - #715

Open
joehart2001 wants to merge 7 commits into
mainfrom
diatomics-download
Open

add diatomic download and share utilities from phonons download#715
joehart2001 wants to merge 7 commits into
mainfrom
diatomics-download

Conversation

@joehart2001

Copy link
Copy Markdown
Collaborator

Pre-review checklist for PR author

PR author must check the checkboxes below when creating the PR.

  • I've confirmed the contribution guidelines.
  • I have reviewed and understand all AI-generated code in this PR.
  • I have added human-written tests for the new logic.
  • I have properly cited any upstream algorithms or libraries the AI utilized.
  • I have disclosed significant AI tool usage in the PR description.

Summary

Linked issue

Resolves #

Testing

@joehart2001 joehart2001 added the new model Proposals and suggestions for new models to test label Jul 21, 2026
@joehart2001

Copy link
Copy Markdown
Collaborator Author

@ElliottKasoar it keeps refusing my changes to pass the pre-commit, any idea?

@ElliottKasoar

Copy link
Copy Markdown
Collaborator

Is this supposed to be labeled as new model?

The functions you're importing don't seem to exist? It's an odd manifestation, but probably why.

@joehart2001 joehart2001 added enhancement New feature or request and removed new model Proposals and suggestions for new models to test labels Jul 21, 2026
@joehart2001

Copy link
Copy Markdown
Collaborator Author

Is this supposed to be labeled as new model?

The functions you're importing don't seem to exist? It's an odd manifestation, but probably why.

sorry nope. ahh i had forgot to add a new utils file, all good now

Comment thread ml_peg/app/utils/build_callbacks.py Outdated

@ElliottKasoar ElliottKasoar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diatomics don't seem to load for me at all with these changes (I checked on main with the same data and it looked ok, so I don't think it's missing data/a loading issue)

image

@joehart2001

Copy link
Copy Markdown
Collaborator Author

The diatomics don't seem to load for me at all with these changes (I checked on main with the same data and it looked ok, so I don't think it's missing data/a loading issue)

image

i had this issue for mace-mp-0b3, and then found i didnt have the analysis/up to date analysis. could you check this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants