Conversation
The `classify_stream_error` function previously only treated `server_error` and `api_error` types as transient. This meant that overload-specific error signals were silently falling through to `StreamError::Other`, making them non-retryable. Two additional cases are now covered: - `service_unavailable_error` type with `code=server_is_overloaded` is the documented in-stream form of OpenAI's 503 "engine is currently overloaded" condition. The discriminator lives in `code`, not `type`, so both fields are now checked. - `overloaded_error` type, used by some OpenAI-compatible providers that reuse Anthropic's error taxonomy. Either a matching `type` or a matching `code` is sufficient to classify the error as transient, preserving any `retry-after` hint that may be present on the error. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
classify_stream_errorfunction previously only treatedserver_errorandapi_errortypes as transient. This meant that overload-specific error signals were silently falling through toStreamError::Other, making them non-retryable.Two additional cases are now covered:
service_unavailable_errortype withcode=server_is_overloadedis the documented in-stream form of OpenAI's 503 "engine is currently overloaded" condition. The discriminator lives incode, nottype, so both fields are now checked.overloaded_errortype, used by some OpenAI-compatible providers that reuse Anthropic's error taxonomy.Either a matching
typeor a matchingcodeis sufficient to classify the error as transient, preserving anyretry-afterhint that may be present on the error.