Add (minimal) bindings to resizeObserver#72
Open
panglesd wants to merge 3 commits into
Open
Conversation
Owner
Owner
|
Now that you spelled it out, I realize I actually never bound |
Owner
|
Sorry @panglesd but I'm not going to merge that for the next release. I think a common strategy should be adopted for all these Observer APIs. But since they are performance sensitive, I'm not sure the API you gave here is the most appropriate (that is converting the array of entries to a list). |
Owner
|
I don't have the time to think about now but just so that I don't forget. I think it's likely better to pass in a fold function (instead of converting the array to a list). This pattern is already used in a few other places for dealing with the iterator protocol and most recently in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds bindings to the ResizeObserver API.
For now, only
targetcan be extracted from entries, but that is a first step.