[WIP] Split ground_truthing/__init__.py into multiple files for improved readability #67
Draft
elliott-ruebush wants to merge 6 commits into
Draft
[WIP] Split ground_truthing/__init__.py into multiple files for improved readability #67elliott-ruebush wants to merge 6 commits into
ground_truthing/__init__.py into multiple files for improved readability #67elliott-ruebush wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Currently all of the tkinter app logic for the ground truthing app lives in
ground_truthing/__init__.py, which makes it harder for humans (and LLMs) to parse.This PR is a pure move of classes/functions into separate files so that the ground truthing logic is more easily navigable. The only code changes that are present are type hint adjustments
[SUBJECT TO CHANGE] Additionally, I'm adding two example files with ADS-B and AIS data for reference if writing unit tests or other logic
Manual Testing
I did a quick smoke test to confirm that the ground truthing app launches and seems to behave with identical functionality after the file reorgs. The
run_ground_truthing.pyscript is unchanged with this update, it's purely a file restructure of the internal ground truthing GUI logic.Unit Testing
I have added some basic unit tests for functionality around audible time ranges and initial limit lines as well. I think these could be refined more for clarity but just wanted to get something down to start.