improvement: cache Daytona client and improve error handling#3
Open
hjpinheiro wants to merge 1 commit into
Open
improvement: cache Daytona client and improve error handling#3hjpinheiro wants to merge 1 commit into
hjpinheiro wants to merge 1 commit into
Conversation
build_client() previously created a new Daytona instance on every tool invocation. Since the plugin daemon is a long-running process, cache the client by credentials hash to avoid redundant connection setup. Also catch DaytonaError (parent class) in get_sandbox() to provide clear ValueError messages for SDK errors beyond not-found (auth failures, rate limits, server errors).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two improvements to
_client.py:1. Client caching
build_client()created a newDaytonainstance (with new HTTP session/connection pool) on every tool invocation. Since the plugin daemon is a long-running process, caching the client by credentials hash avoids redundant connection setup.The cache key is a SHA-256 hash of
api_key+api_url, so different credentials get different clients.2. Broader error handling in
get_sandbox()Previously only
DaytonaNotFoundErrorwas caught. SDK errors like auth failures, rate limits, or server errors leaked as raw exceptions. Now also catchesDaytonaError(the parent class) and converts to a descriptiveValueError.Testing
py_compilepassesDaytonaErrorimport verified againstdaytona==0.187.0