fix: add file size limits to prevent plugin OOM crashes#2
Open
hjpinheiro wants to merge 1 commit into
Open
Conversation
Without size checks, uploading or downloading large files (e.g. multi-GB datasets) can exhaust the plugin daemon memory and crash the entire plugin process. - Add MAX_FILE_SIZE (100 MB) constant in _client.py - upload_file: check blob size before uploading - download_file: check file info size before downloading, and verify downloaded content size as a safety net
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
upload_fileanddownload_filetools have no file size checks. A large file (multi-GB dataset, log file, etc.) can exhaust the plugin daemon memory and crash the entire plugin process.Changes
_client.py: AddMAX_FILE_SIZE = 100 MBshared constanttools/upload_file.py: Checkfile.blobsize before uploadingtools/download_file.py: Check file metadata size viaget_file_info()before downloading (avoids downloading the file at all), with a post-download size check as a safety netBehavior
ValueErrorwith clear messageValueErrorbefore transfer startsThe 100 MB limit is a safe default for a plugin daemon with 256 MB memory (
resource.memory: 268435456inmanifest.yaml).