feat(client): shared "Trained Styles" copy catalog + web relabel#285
Draft
leszko wants to merge 1 commit into
Draft
feat(client): shared "Trained Styles" copy catalog + web relabel#285leszko wants to merge 1 commit into
leszko wants to merge 1 commit into
Conversation
… tooltips
Adds packages/demon-client/copy/ — a framework-agnostic module of plain
string constants that is the single source of truth all three DEMON
frontends (web demo, public demo, VST webui) read for:
- terminology: the "LoRA" → "Trained Styles" player-facing rename
- short UI labels (library header, search, blend, empty/refit states)
- tooltip copy for cross-client controls (strength/structure/timbre
macros + Trained Style strength/blend)
The engine, wire protocol, config keys, and admin training studio keep
the honest technical term "LoRA"; only player-facing UI is renamed.
Wires the web demo to the catalog: relabels LibraryTile, MobileStepperRail,
AdvancedDrawer, HeroMacros, OperatorStrip, ScheduleCurvesOverlay, and routes
SliderTile's macro + Trained Style tooltips through the shared source.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
leszko
requested review from
hthillman and
ryanontheinside
and removed request for
hthillman and
ryanontheinside
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Introduces a single, framework-agnostic source of truth for player-facing copy that all three DEMON frontends (this web demo,
demon-public-demo,rtmg-vst) can share, and uses it to rename the player-facing "LoRA" concept to "Trained Styles".New shared module —
packages/demon-client/copy/Plain string constants, zero runtime deps:
terms.ts— the canonicalTRAINED_STYLES/TRAINED_STYLErename. Engine, wire protocol, config keys, MIDI map, and the admin training studio keep the honest technical term "LoRA"; only player-facing UI is renamed.labels.ts—LABELS: library header, search placeholder/aria, empty + refit states, blend label.tooltips.ts—TOOLTIPS+sharedTooltipFor(param)for the controls that exist in every client (strength / structure / timbre macros + Trained Style strength/blend).Exported from the SDK's
index.ts; bundled intodist/.Web demo wired to the catalog
Relabeled
LibraryTile,MobileStepperRail,AdvancedDrawer,HeroMacros,OperatorStrip,ScheduleCurvesOverlay;SliderTilenow routes its macro + Trained Style tooltips through the shared source so wording can't drift.Why
"tooltip everything, shared between clients" + "relabel loras to 'Trained Styles'" from the UX backlog. There was no shared UI-copy layer before (
@demon/clientwas SDK-only); this adds the minimal one.Downstream
demon-public-demopicks this up vianpm run sync-ui(mirrors bothvendor/demon-uiandvendor/demon-client), then relabels its own Radio/Help surfaces — separate PR, depends on this merging.rtmg-vstrelabels independently (no@demon/clientwiring) — separate PR.Test
tsc --noEmitpasses for the SDK and the web app.🤖 Generated with Claude Code