Convert to Drush 9 commands#18
Conversation
fgm
force-pushed
the
17-drush_9_commands
branch
9 times, most recently
from
7a8bb7c to
dc3b648
Compare
fgm
force-pushed
the
17-drush_9_commands
branch
from
dc3b648 to
ef1d248
Compare
fgm
force-pushed
the
17-drush_9_commands
branch
from
dab1e97 to
5e50bf9
Compare
andypost
left a comment
andypost
left a comment
There was a problem hiding this comment.
I see only enable/disable needs work
| } | ||
|
|
||
| // Skip already-enabled languages. | ||
| if ($languages[$langcode]->enabled) { |
There was a problem hiding this comment.
I bet it should use status() instead of property
| $messageArgs = ['langcode' => $langcode]; | ||
|
|
||
| // In the foreach loop because the list changes on successful iterations. | ||
| $languages = $this->languageManager->getLanguages(); |
There was a problem hiding this comment.
please move it out of loop
| } | ||
|
|
||
| // FIXME find the D8 equivalent: this is D7 logic. | ||
| db_update('languages') |
There was a problem hiding this comment.
Guess it ->enable()->save()
|
|
||
| // FIXME probably needs a more generic invalidation. | ||
| // Changing the language settings impacts the interface. | ||
| $this->cachePage->deleteAll(); |
There was a problem hiding this comment.
Maybe better to clear all caches? IIRR mostly all caches are depends on language & IMO better to clear them conditionally if any language actually changed
|
@andypost interesting comments, but IMHO off-topic: this is just about converting from the Drush 8 format to the Drush 9 format, so that it can be merged sooner. Actually fixing the commands is another topic. Very much needed too, but separate. |
|
+1 for not trying to change the world! |
|
Sure, there's more work ahead! |
|
I think we should merge this, at least there is something which works for someone. |
fgm
force-pushed
the
17-drush_9_commands
branch
from
c5cfd41 to
44eda66
Compare
|
Yes, lets start 2.x brach with drush 9 |
|
Huch, why should we create a new branch, when there is nothing broken?
Minor changes are used for new features.
Andy Postnikov <notifications@github.com> schrieb am Mi., 29. Nov. 2017 um
20:29 Uhr:
… Yes, lets start 2.x brach with drush 9
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABz7ukGxxsUD4bj2my88Nbv3L7PhQ9Pks5s7b6qgaJpZM4P0M9_>
.
|
|
Hello, I have worked on this today. Please see my comments starting from https://www.drupal.org/project/drush_language/issues/2914081#comment-12486797 to https://www.drupal.org/project/drush_language/issues/2914081#comment-12487040 |
|
@andypost: enable and disable commands have been removed because languages in Drupal 8 don't have this attribute anymore. Also the default language command neither worked or had been used. |
5 participants
Commands converted on top of the current 8.x-1.x drupal.org HEAD.