Mimic language import options from core import form#10
Open
goechsler wants to merge 1 commit into
Open
Conversation
dawehner
reviewed
Dec 27, 2016
| // Evaluate overwriting options. | ||
| $replace_customized = (NULL !== drush_get_option('replace-customized')); | ||
| $replace_non_customized = (NULL !== drush_get_option('replace-non-customized')); | ||
| if (NULL !== drush_get_option('replace-customized')) { |
Owner
There was a problem hiding this comment.
Can't you provide a default value when using drush_get_option? This could simplify the new code a bit. Maybe i'm just entirely wrong
Owner
|
Note: the project got merged back into drupal.org |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added some options to be able to perform tasks like I would do on the core import form.
In order to avoid breaking bc with the current behavior I defaulted the --customized option to TRUE, which leads to the weird usage to turn it off on demand :/