[CMPT-7182] feat(pipeline): add --python-version to image create/update; deprecate --base-image - #744
Open
sunny2get wants to merge 4 commits into
Open
Conversation
…te; deprecate --base-image Mirror the pipelines-api change (PR datarobot-oss#246): pythonVersion is now the canonical way to pick a pipeline image's interpreter, and pythonBaseImage is deprecated. - create/update: new --python-version flag (e.g. 3.11; allowed 3.10-3.13), threaded into CreateImage/UpdateImage and the request bodies (pythonVersion). - --base-image is marked DEPRECATED in help: a bare version folds into pythonVersion server-side; a full image ref is ignored at build time. Flag still accepted for back-compat; examples no longer advertise python:3.12. - image.go: PythonVersion added to ImageDefinition + create/update request structs. Output: python_version in JSON, a PYTHON column in the human table. go build + go test ./internal/pipeline/... ./cmd/pipeline/image/... pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XpPjzRu2VLgbbKd9WJ9sML
|
🎫 Jira: |
…/update Mirrors the pipelines-api rename of the image-definition ``nvidia`` field to the vendor-neutral ``gpu``. Adds a canonical ``--gpu`` flag and keeps ``--nvidia`` as a deprecated hidden alias (cobra MarkDeprecated) so existing scripts keep working. Request/response structs and JSON output now use the ``gpu`` wire key; the API canonicalises on ``gpu`` and still accepts the ``nvidia`` alias. Note: ``gpu: true`` is rejected with 422 by environments without GPU capacity (the new ``gpu_enabled`` server flag). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XpPjzRu2VLgbbKd9WJ9sML
…ommands Doc-sync for the --nvidia → --gpu rename: the pipeline image command reference now shows the canonical --gpu flag with --nvidia noted as a deprecated alias, and "NVIDIA GPU support" prose reads "GPU support". Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XpPjzRu2VLgbbKd9WJ9sML
…clop printImageVersionsHuman was at cyclomatic complexity 12 (max 10) after the PYTHON column was added. Extract the per-version cell formatting into imageVersionRow, dropping the function well under budget. Behaviour-preserving; GPU stays JSON-only (it never had a human-table column, same as nvidia before). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XpPjzRu2VLgbbKd9WJ9sML
sunny2get
marked this pull request as ready for review
August 6, 2026 18:57
Contributor
Author
|
/approve-smoke-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the pipelines-api change (datarobot/pipelines-api#246):
pythonVersionis now the canonical way to select a pipeline image's Python interpreter, andpythonBaseImageis deprecated.Changes
dr pipeline image create/update: new--python-versionflag (e.g.3.11; allowed3.10–3.13), threaded intoCreateImage/UpdateImageand the request bodies aspythonVersion.--base-imagemarked DEPRECATED in help text. Server-side a baremajor.minorvalue folds intopythonVersion; a full image reference is accepted but ignored at build time (it would bypass the FIPS base). The flag still works for back-compat; examples no longer advertisepython:3.12.internal/pipeline/image.go:PythonVersionadded toImageDefinition+ create/update request structs.python_versionin--output-format json; aPYTHONcolumn in the human table.Testing
go build ./...andgo test ./internal/pipeline/... ./cmd/pipeline/image/...pass.Draft pending the pipelines-api PR (#246) merging + the version endpoint being available in the target environment.
🤖 Generated with Claude Code
https://claude.ai/code/session_01XpPjzRu2VLgbbKd9WJ9sML
Note
Medium Risk
Changes the image create/update API payload and CLI flags users rely on for execution environments; backward-compat aliases limit breakage but behavior depends on the paired pipelines-api release.
Overview
Aligns
dr pipeline image createandupdatewith pipelines-api:--python-versionis the canonical way to pick the Python interpreter (sent aspythonVersion);--base-imageis deprecated in help (baremajor.minorstill forwarded; full image refs are API-defined as ignored at build time).GPU naming: requests use
gpuon the wire instead ofnvidia. The CLI adds--gpuand keeps--nvidiaas a deprecated alias (gpu || nvidia). JSON output exposespython_versionandgpu; the human version table gains a PYTHON column.CreateImage/UpdateImagesignatures and structs ininternal/pipeline/image.gowere extended accordingly; tests and docs were updated to match.Reviewed by Cursor Bugbot for commit 47a59b9. Configure here.