[RAPTOR 18595] Schema change: acceptance test fixture

[brunoromano-dr]

RATIONALE

Adds HTTP-level acceptance tests for the workload autoscaling schema change (workload-api#984): lock the dr workload create path for the new payload shape and document that preflight validation runs before POST.

Follows RAPTOR-18591 (docs/examples) and RAPTOR-18594 (preflight validation). PR 3 from the internal SCHEMA_CHANGE_CLI.md plan.

Ticket: RAPTOR-18595

CHANGES

File	Change
internal/workload/workload_test.go	TestCreateWorkload_AutoscalingShapePostsVerbatimAndParses201 — validate + POST autoscaling spec verbatim → 201
internal/workload/workload_test.go	TestCreateWorkload_PreflightRejectsReplicaCountWithAutoscaling — conflict spec fails validation; no HTTP call

TESTING

GOPROXY=https://proxy.golang.org,direct go test ./internal/workload/ -run 'TestCreateWorkload_(AutoscalingShape|Preflight)' -v

Full package:

GOPROXY=https://proxy.golang.org,direct go test ./internal/workload/ -v

RELATED

• RAPTOR-18591 — autoscaling docs and docs/examples/workload-autoscaling.yaml
• RAPTOR-18594 — validateRuntimeReplicaAutoscaling in workload.go
• WAPI: workload-api#984

PR Automation

Comment-Commands: Trigger CI by commenting on the PR:

• /trigger-smoke-test or /trigger-test-smoke - Run smoke tests
• /trigger-install-test or /trigger-test-install - Run installation tests

Labels: Apply labels to trigger workflows:

• run-smoke-tests or go - Run smoke tests on demand (only works for non-forked PRs)

Important

For Forked PRs: The run-smoke-tests label won't work. A required Smoke Tests check will block merge until a maintainer acts:

• A maintainer uses /approve-smoke-tests to run smoke tests (results will set the check)
• A maintainer uses /skip-smoke-tests to bypass the check without running tests

Please comment requesting a maintainer review if you need smoke tests to run.

Branch: RAPTOR-18595-schema-change-acceptance-test-fixture → datarobot-oss:main (stack after RAPTOR-18594 / RAPTOR-18591)

Diff size: 1 file (workload_test.go)

Made with Cursor

[datarobot-pr-review-router]

👋 Thanks so much for contributing to the DataRobot community!

As a quick heads-up on how our team handles reviews: if you're still iterating on
this code or running tests, please feel free to convert this to a Draft PR.
We rely heavily on GitHub Drafts to give contributors a stress-free sandbox to experiment!

Once everything is finalized and you're ready for feedback, just click "Ready for review"
and the maintainers will be notified to jump in. (And if this PR is already 100% ready
to go, no action needed, we'll take a look soon!)

[datarobot-pr-review-router]

Code Ownership

Workload Cli

• internal/workload/workload.go
• internal/workload/workload_test.go

Review requested from the teams above. Labels will be removed automatically upon approval.

[chasdr]

re-reviewed after the head moved. the preflight test now lives in cmd/workload/create/cmd_test.go and drives cmd.Execute(), so posted==false actually proves the short-circuit. verified it passes and fails for the right reason (the mutual-exclusivity error fires before any POST), lint clean. LGTM 👍

[brunoromano-dr]

Hi @chasdr , why are the smoke tests still waiting for status to be reported? Trying to push this PR towards closing if it's all right

[github-actions]

🔐 Fork smoke tests started by maintainer

⏳ Security scans passed. Running smoke tests...

Commit: 661af728e18ac2c560bca7b7c72c4ba0b57f7171
View run

[github-actions]

✅ All smoke tests passed! (Fork PR)

✅ Security Scan: success
✅ Linux: success
✅ Windows: success

View run details

[ajalon1]

@brunoromano-dr Is this still ready to go? Need @adamalpi or @wojtekwdr review?