This repository was archived by the owner on Aug 21, 2023. It is now read-only.
Escaping XML entities on strings#6
Open
joshmcarthur wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thanks heaps for porting AWS to a usable version of rails - it has really saved me some time getting Rails talking to a SOAP API.
This may be a slightly contentious point, but I found I was having problems using AWS since it was not escaping XML entities - specifically, the & symbol.
My fix is really simple - to escape any HTML characters in a string member of a struct, by wrapping CGI.escapeHTML around the value.to_s in the casting.rb file - which will of course escape HTML any time a string member is being outputted, which in turn should result in valid and well-formed XML being produced.