Adjust percentile bench case#422
Closed
liammclennan wants to merge 2 commits into
Closed
Conversation
Member
|
Perhaps we could get around this for our scenario just by passing a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because ticks have a constant time range (30s)
flaretl generateperformance is linearly correlated to the time range events are generated for. Hence, the nightly bench now uses a 2 hour time range (120 ticks). This made the percentile query time grouping (12h) too large to produce more than one group, which made the query serial and regressed the benchmark.Switching to 2m time groups over two hours.