Fix/quickstart demo flow#75
Merged
shirshanka merged 5 commits intoJun 29, 2026
Merged
Conversation
DataHub v1.5+ requires DATAHUB_TOKEN_SERVICE_SIGNING_KEY and DATAHUB_TOKEN_SERVICE_SALT to be non-empty. Without them the system-update container fails on a fresh install. Auto-generate both with openssl rand if not already set in the environment.
…ted config The agent defaults to reading config.yaml from ~/.datahub/analytics-agent/ which does not exist inside the container. Without ENGINES_CONFIG pointing at /app/config.yaml, the bootstrap seeds no engines and the agent starts with no data source connected.
….internal The native demo flow runs the agent directly on the host machine, so MySQL and DataHub GMS are reachable via localhost. Using host.docker.internal caused DNS resolution failures on some macOS setups and always fails on Linux where Docker Desktop is not available.
# Conflicts: # backend/src/analytics_agent/quickstart.py
The DataHub v1.5+ signing-key auto-generation relies on `openssl rand`. Without openssl the keys would be silently empty, reintroducing the signing-key error this flow fixes. Add it to the prerequisite checks so the failure is caught up front with a clear install hint. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
shirshanka
approved these changes
Jun 29, 2026
shirshanka
left a comment
shirshanka
left a comment
Contributor
There was a problem hiding this comment.
Approving. Three small, correct quickstart fixes — verified against current main (rebased; only a one-line docstring conflicted with #74's Fiction Retail rename, resolved to main's wording):
- Signing-key auto-gen: DataHub v1.5.0.6+ requires DATAHUB_TOKEN_SERVICE_SIGNING_KEY / _SALT to be non-empty; auto-generated via openssl if unset, exported before the compose runs. Correct placement.
- ENGINES_CONFIG=/app/config.yaml in the .env.quickstart heredoc so the dockerized agent reads the mounted config (no duplicate with #76).
- localhost for the native --demo flow: correct, since the agent runs natively on the host and reaches the containers via published ports. _HOST_INTERNAL is correctly retained for _ingest_metadata, whose ingestion executor runs inside Docker — the host/internal split is intentional and right.
Verified: import OK, ruff + mypy clean, 10 quickstart unit tests pass.
Pushed one hardening commit (maintainer edit): added check_cmd openssl to the prerequisites, since the signing-key generation depends on it — without it the keys would be silently empty and reintroduce the very error this fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
bash quickstart.shcompletes without signing key erroranalytics-agent quickstart --democonnects to MySQL on all platforms