[DRAFT] Refactor PyPI packages version query#2371
Draft
ashenm wants to merge 1 commit intodatabrickslabs:mainfrom
Draft
[DRAFT] Refactor PyPI packages version query#2371ashenm wants to merge 1 commit intodatabrickslabs:mainfrom
ashenm wants to merge 1 commit intodatabrickslabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
What does this PR do?
Replaces the previous direct
requests.getcall to PyPI for package version lookup with a pip invocation instead. This allows the lookup to automatically respect the existing pip.conf configuration, including custom indexes, mirrors, proxies, and authentication settings.Relevant implementation details
Package version resolution now uses
pip index versions --jsonand parses the structured output instead of calling the package index directly over HTTP. This makes the behaviour consistent with the user’s configured Python packaging environment and avoids maintaining separate logic for custom PyPI endpoint handling.Caveats/things to watch out for when reviewing:
Linked issues
Functionality
databricks labs lakebridge ...Tests