Adding feature to integrate Teradata profiler with Lakebridge#2343
Open
dey-abhishek wants to merge 26 commits intomainfrom
Open
Adding feature to integrate Teradata profiler with Lakebridge#2343dey-abhishek wants to merge 26 commits intomainfrom
dey-abhishek wants to merge 26 commits intomainfrom
Conversation
…ction/dataframe normalization
…d when use_pdcr=False
…ion testing for TD
…r_replace_dashboard, causing a cryptic AssertionError on dashboard.dashboard_id assertion instead of the real SDK error
…reased the SQL preview for top queries in dashboard
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2343 +/- ##
==========================================
+ Coverage 66.10% 68.53% +2.43%
==========================================
Files 99 99
Lines 9291 9539 +248
Branches 989 1037 +48
==========================================
+ Hits 6142 6538 +396
+ Misses 2970 2781 -189
- Partials 179 220 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ 143/143 passed, 11 flaky, 20 skipped, 1h11m58s total Flaky tests:
Running from acceptance #4086 |
Author
|
Hi @sundarshankar89 - Pls. share your review comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
What does this PR do?
Adds end-to-end Teradata profiler support and hardens the Teradata assessment workflow with:
SQLTextInfoin Unity CatalogRelevant implementation details
resources/assessments/teradata/:lakebridge_teradata_profiler_summary.lvdash.jsonTop QueriesSQL preview truncation from 120 to 300 charsuse_pdcrin credentialscreate-profiler-dashboardnow auto-resolves extract path from pipeline config when--extract-fileis omittedassessments/dashboards/execute.py) improvements:td_dbql_core_info_extract.SQLTextInfoLAKEBRIDGE_ENABLE_SQLTEXT_MASK=trueLAKEBRIDGE_SQLTEXT_MASK_BYPASS_GROUPCaveats/things to watch out for when reviewing:
tests/integration/assessments/test_pipeline.pyrequireTEST_TSQL_JDBC; unrelated to Teradata but may fail in environments where it is absent.SQLTextInfomay still contain sensitive business SQL if masking is not enabled.create-profiler-dashboardnow infers extract path from the configured pipeline; custom extract paths still require explicit--extract-file.Linked issues
Resolves #..
Functionality
databricks labs lakebridge create-profiler-dashboardSQLTextInfoSQLTextInfoTests