Fix pre-existing CI failures: ty typecheck and openai cross-version tests#454
Open
fanzeyi wants to merge 1 commit into
Open
Fix pre-existing CI failures: ty typecheck and openai cross-version tests#454fanzeyi wants to merge 1 commit into
fanzeyi wants to merge 1 commit into
Conversation
dhruv0811
approved these changes
Jul 16, 2026
…ests Two pre-existing CI failures on main: 1. typechecking for integrations/langchain (ty check): test_multi_server_mcp_client.py line 54 accessed .seconds on a union of float|timedelta. Add isinstance check to narrow the type so ty recognizes the timedelta attribute access. 2. openai cross-version tests (v0.3.0, v0.4.0, v0.5.0): The mock_vs_client fixture patches databricks.ai_search.client .VectorSearchClient but older integrations import via the deprecated databricks.vector_search.client.VectorSearchClient shim. mock.patch only replaces the attribute on the specific module, so the old import path was not mocked and the real VectorSearchClient tried to authenticate. Now the fixture also patches the old path when the shim module is installed. Both fixes are backward compatible.
fanzeyi
force-pushed
the
fix/ci-pre-existing-failures
branch
from
July 16, 2026 23:44
f24db7c to
db93449
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two pre-existing CI failures on main:
typechecking for integrations/langchain (ty check): test_multi_server_mcp_client.py line 54 accessed .seconds on a union of float|timedelta. Add isinstance check to narrow the type so ty recognizes the timedelta attribute access.
openai cross-version tests (v0.3.0, v0.4.0, v0.5.0): The mock_vs_client fixture patches databricks.ai_search.client .VectorSearchClient but older integrations import via the deprecated databricks.vector_search.client.VectorSearchClient shim. mock.patch only replaces the attribute on the specific module, so the old import path was not mocked and the real VectorSearchClient tried to authenticate. Now the fixture also patches the old path when the shim module is installed.
Both fixes are backward compatible.