feat(query): add New Flight transport - #20397
Open
dqhl76 wants to merge 5 commits into
Open
Conversation
dqhl76
force-pushed
the
flight-split-01-new-flight-inbound
branch
from
August 27, 2026 06:05
7f734d9 to
d79c785
Compare
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
dqhl76
force-pushed
the
flight-split-01-new-flight-inbound
branch
2 times, most recently
from
August 27, 2026 06:41
af1762d to
a1d76eb
Compare
Contributor
Docker Image for PR
|
Contributor
🤖 CI Job Analysis
📊 Summary
❌ NO RETRY NEEDEDAll failures appear to be code/test issues requiring manual fixes. 🔍 Job Details
🤖 AboutAutomated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed). |
dqhl76
force-pushed
the
flight-split-01-new-flight-inbound
branch
3 times, most recently
from
August 30, 2026 06:39
3132523 to
49dfaf2
Compare
dqhl76
force-pushed
the
flight-split-01-new-flight-inbound
branch
from
August 30, 2026 09:17
87b234a to
8f4438c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
This PR adds the complete default-off New Flight transport and separates transport mechanics from exchange-domain pipeline code.
It includes:
DoExchangetransport/legacy,transport/reliable, and exchange-owned adaptersImplementation
The old mixed
v1/networkmodule is replaced by two explicit transport implementations:v1/transport/legacy: the existing ping-pong transport and outbound bufferv1/transport/reliable: protocol framing, reconnect policy, logical inbound/outbound state machines, and theReliableInboundDeliveryboundaryExchange-specific concerns remain under
v1/exchange, includingDataBlockserialization, local channels, quota queues, TID/batch routing, pipeline processors, and statistics delivery. The reliable transport operates onFlightDataand no longer depends onSettings,DataBlock, pipeline types, orQueryContext.The setting-to-transport conversion is also owned by the exchange layer, so transport selection remains outside the protocol implementation.
Compatibility and rollout
enable_experiment_new_flightdefaults to0.Enable
Tests
Focused tests cover wire compatibility, packet validation, replay deduplication, reconnect lease replacement, reconnect budget exhaustion, sender/receiver failure propagation, legacy ping-pong and buffering, fragment TID routing, statistics completion/failure, and end-to-end exchange setup/cleanup.
Type of change
AI assistance
This change is