Skip to content

Fix masked array deserialization overflow for integer dtypes #9193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abslock128w wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −0
Open

Fix masked array deserialization overflow for integer dtypes #9193

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e154cdf
Fix masked array deserialization overflow for integer dtypes
abslock128w Feb 6, 2026
2243e71
Update numpy.py
abslock128w Feb 6, 2026
8866074
Apply black formatting
abslock128w Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions distributed/protocol/numpy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,4 +216,11 @@ def deserialize_numpy_maskedarray(header, frames):
if pickled_fv:
fill_value = pickle.loads(fill_value)

# Ensure fill_value is compatible with dtype
if fill_value is not None:
try:
fill_value = np.array(fill_value, dtype=data.dtype).item()
except (OverflowError, ValueError, TypeError):
Copy link
Copy Markdown
Collaborator

@crusaderky crusaderky May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your opening post mentions only TypeError. What are the use cases for OverflowError and ValueError?

fill_value = np.ma.default_fill_value(data.dtype)

return np.ma.masked_array(data, mask=mask, fill_value=fill_value)
Loading