Skip to content

Add n_iter_ attribute to estimators#79

Open
pentschev wants to merge 5 commits into
dask:mainfrom
pentschev:n_iter-attribute
Open

Add n_iter_ attribute to estimators#79
pentschev wants to merge 5 commits into
dask:mainfrom
pentschev:n_iter-attribute

Conversation

@pentschev

@pentschev pentschev commented Mar 20, 2019

Copy link
Copy Markdown
Member

After this is merged, Dask-ML must be adapted to this change as well.

https://github.com/dask/dask-ml/blob/master/dask_ml/linear_model/glm.py#L187

Solves #77.

@mrocklin

Copy link
Copy Markdown
Member

cc @jrbourbeau @cicdw

@jrbourbeau jrbourbeau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @pentschev, this PR looks really good!

Minor comment: could you please add an n_iter_ attribute to the estimator docstrings

Also, as you mentioned, these changes will cause breakage in dask-ml. Do you have an interest in updating the estimators over there too? Definitely no obligation though, just wanted to check

Comment thread dask_glm/algorithms.py Outdated
@pentschev

Copy link
Copy Markdown
Member Author

Minor comment: could you please add an n_iter_ attribute to the estimator docstrings

Yes, thanks for pointing that I forgot it.

Also, as you mentioned, these changes will cause breakage in dask-ml. Do you have an interest in updating the estimators over there too? Definitely no obligation though, just wanted to check

Yes, I planned to do that once this was merged, I think there's no point in already opening an PR there before this gets reviewed here.

@jrbourbeau

Copy link
Copy Markdown
Member

Yes, I planned to do that once this was merged

Awesome, thank you @pentschev

@pentschev

Copy link
Copy Markdown
Member Author

From my side, this is ready for another review/merge.

@jrbourbeau jrbourbeau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pentschev

Copy link
Copy Markdown
Member Author

Are we good to merge this?

Base automatically changed from master to main February 10, 2021 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants