fix(memory,chat): remove dead Memory Books actions, generation connection picker, send/generation race - #3
Closed
danvitv wants to merge 1 commit into
Closed
Conversation
…nnection picker, fix send/generation race - Remove dead Dedup button and 'Only selected swipes' toggle from Memory Books, plus all connected code: MemoryDedupService, MemorySwipeFilter, runDedup, memoryDedupServiceProvider, memoryDedupThreshold. - Remove empty Write loop no-op (_replaceLegacyWriteLoopPrompts); legacy compatibility cleanup migrations are preserved. - Add apiConfigId to MemoryBookApiSettings and a new MemoryBookApiConfigResolver so Memory Books can use a saved API connection without changing the global chat profile. The settings sheet gains a connection dropdown; model fetch now resolves against the selected profile. - Fix user/assistant message ordering race: isGenerating is no longer published in the optimistic state before the durable DB append, so the assistant placeholder cannot appear above the user bubble. A _sendInFlight guard prevents double-send. - Replace machine-specific local paths in tracked docs with PATH/env placeholders; original paths catalogued in an untracked docs/LOCAL_PATH_REFERENCES.md.
Owner
Author
|
Opening against upstream instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four concerns on top of current nightly.
1. Dead Memory Books buttons removed
Dedup button and Only selected swipes toggle removed with full chain: MemoryDedupService, MemorySwipeFilter, runDedup, memoryDedupServiceProvider, memoryDedupThreshold, toolbar tile, overview switch, 4 translation keys.
2. Write loop dead code
Removed empty no-op _replaceLegacyWriteLoopPrompts() and its v66 call. Legacy compatibility cleanup migrations preserved.
3. Memory Books generation connection picker
Added apiConfigId on MemoryBookApiSettings, MemoryBookApiConfigResolver, connection dropdown in settings sheet, MemoryDraftGenerator uses resolver. Does not change global active connection.
4. User/assistant message ordering race
isGenerating now published only after durable DB append. _sendInFlight guard prevents double-send.
5. Local path cleanup
Machine-specific paths removed from 6 tracked docs, replaced with PATH/env placeholders.
Verification