make midi out work with mod-provided ports such as nbout - #17
Open
jstefani wants to merge 1 commit into
Open
Conversation
The midi out device was connected at file scope, which runs before the script_pre_init hook where mods like nbout replace the midi table with a proxy that serves the virtual "nb" port. The script therefore always held the real (empty) port 1 and nbout never received notes. Connect in init instead, after params exist, and reconnect from the param action. Also size 'midi out device' from #midi.vports (16, or 17 with nbout) instead of a hardcoded 4, and show the port name next to the number. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Author
|
code by Fable 5.1 Testedmonome 64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The midi out device was connected at file scope, which runs before the script_pre_init hook where mods like nbout replace the midi table with a proxy that serves the virtual "nb" port. The script therefore always held the real (empty) port 1 and nbout never received notes. Connect in init instead, after params exist, and reconnect from the param action.
Also size 'midi out device' from #midi.vports (16, or 17 with nbout) instead of a hardcoded 4, and show the port name next to the number.