feature - implement RFC 022 format functions (#39)#49
Merged
Conversation
083dfc2 to
298a26f
Compare
4ebb788 to
c786443
Compare
2 tasks
ca19b08 to
381de0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sha2(...)kept as a compatibility rewrite over concrete SHA-2 helpersinql-datafusion-formatadapter crate; the remaining adapter logic is Incan source using Rust bridge imports only where neededfrom_json[Payload](...)andfrom_csv[Row](...)Type of change
docs/rfcs/*)Area(s)
Key details
md5,sha1, concrete SHA-2 helpers,sha2,crc32,xxhash64), URL parse/encode/decode helpers, JSON validation/path/schema helpers, and CSV row/schema helpers in scalar projections.from_json[T](...),try_from_json[T](...), andfrom_csv[T](...)derive schema metadata from compiler-provided Incan model/class type reflection. The public API uses the model type parameter directly, not schema strings, dummy model values, or schema wrapper helpers.src/session/datafusion_format_functions.incnrather than a package-local Rust crate.typeof,is_array, andis_objectremain unavailable until a variant value model exists.0.3.0-rc28, which includes the generic decorated type-parameter reflection and Rust string-boundary fixes needed by the model-typed JSON/CSV helpers.Testing / verification
Verified locally with Incan
0.3.0-rc28from mergedrelease/v0.3:cargo build --bin incanin/Users/danny/Development/encero/incanmake test INCAN=/Users/danny/Development/encero/incan/target/debug/incanmake fmt-check INCAN=/Users/danny/Development/encero/incan/target/debug/incanmake test-style INCAN=/Users/danny/Development/encero/incan/target/debug/incanmake registry-metadata INCAN=/Users/danny/Development/encero/incan/target/debug/incanmake build INCAN=/Users/danny/Development/encero/incan/target/debug/incanmake smoke-consumer INCAN=/Users/danny/Development/encero/incan/target/debug/incangit diff --checkNotes:
make testpassed 175 package tests.make registry-metadatapassed with 130 helpers and still prints the knownincan.lock is out of datepackage-root warning.make smoke-consumerattempt failed because DNS could not resolveindex.crates.io; rerunning the same command with network access passed.Docs impact
Links:
docs/language/reference/functions/format.md,docs/language/reference/functions/index.md,docs/release_notes/v0_1.md,docs/rfcs/022_semi_structured_format_functions.md,docs/rfcs/README.mdStack / Merge Order
Incan
0.3.0-rc28is merged onrelease/v0.3; this PR is now unblocked by the compiler fixes. This PR is full RFC 022 scope and closes #39.Refs #39
Refs dannys-code-corner/incan#708
Refs dannys-code-corner/incan#709
Refs dannys-code-corner/incan#714
Refs dannys-code-corner/incan#715
Refs dannys-code-corner/incan#716