Skip to content
This repository was archived by the owner on Mar 8, 2018. It is now read-only.

Fix Django 1.7 compatibility.#12

Open
olivierb2 wants to merge 2 commits into
daniviga:masterfrom
olivierb2:master
Open

Fix Django 1.7 compatibility.#12
olivierb2 wants to merge 2 commits into
daniviga:masterfrom
olivierb2:master

Conversation

@olivierb2

Copy link
Copy Markdown

Hi,

I created a fix for Django 1.7. Free to you if you want integrate it or not.

Best regards.

Olivier.

@PenguinzTech PenguinzTech left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one possible change that isn't related to these changes, looks good!

@@ -141,13 +144,13 @@ class CompatibilityMixIn(object):
console_socket) = get_connection_infos(token)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console_socket) ? What's the end of parenthesis for?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made problably a mistake (wrong copy/paste). You can remove this last out of the scope of the patch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants