Skip to content

perf(region): skip full repaint on idle/no-op redisplays #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielxvu merged 1 commit into from
Jul 6, 2026
Merged

perf(region): skip full repaint on idle/no-op redisplays #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/display.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,18 +678,24 @@ update(int modelinecolor)
}
hflag = FALSE; /* Not hard. */
for (wp = wheadp; wp != NULL; wp = wp->w_wndp) {
#ifdef ENABLE_NATIVE_MAGIT
/* The current window's active region repaints fully so the
* standout tracks point (only curwp's region is drawn). */
if (wp == curwp && (wp->w_flag & WMARKED))
wp->w_rflag |= WFFULL;
#endif
/*
* Nothing to be done.
*/
if (wp->w_rflag == 0)
continue;
#ifdef ENABLE_NATIVE_MAGIT
/*
* The current window's active region must repaint enough of the
* window to move the standout with point, so escalate a redraw
* that is ALREADY needed to a full one. Doing this only when the
* window already has redisplay flags set means an idle cycle
* (e.g. a background magit refresh) or a no-op key leaves the
* region as-is instead of re-rendering every row for nothing.
* (uline diffs cells, so a genuine move still emits only the
* boundary rows whose highlight actually changed.)
*/
if (wp == curwp && (wp->w_flag & WMARKED))
wp->w_rflag |= WFFULL;
region_hl_setup(wp); /* order the mark/point span for this window */
#endif

Expand Down
Loading